feat: hook pre/post merge include merge source #8703
+30
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new field `merge_source` include source branch/tag/commit as requested. The current event include `source_ref` which resolved to the specific commit the merge operation will merge.
nopcoder
added
area/hooks
|
🎊 PR Preview 4151122 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-8703.surge.sh 🕐 Build time: 0.011s
🤖 By surge-preview |
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
Isan-Rivkin
requested changes
Feb 27, 2025
| | tag_id[^3] | The ID of the created/deleted tag | string | | ||
| | merge_source[^5] | The source branch/tag/ref on merge operation | string | |
There was a problem hiding this comment.
This renders as 4? (see image with purple arrow)
| @@ -73,13 +73,15 @@ Upon execution, a webhook will send a request containing a JSON object with the | |||
| | commit_message[^2] | The message for the commit (or merge) that is taking place | string | | |||
| | committer[^2] | Name of the committer | string | | |||
| | commit_metadata[^2] | The metadata for the commit that is taking place | string | | |||
| | commit_id[^2,^4] | The ID of the commit that is being created | string | | |||
| | commit_id[^2,^4] | The ID of the commit that is being created | string | | |||
There was a problem hiding this comment.
not rendering (see screenshot in comment blueish' arrow)
There was a problem hiding this comment.
Thanks, I'll fix it
| @@ -37,6 +38,7 @@ func marshalEventInformation(actionName, hookID string, record graveler.HookReco | |||
| CommitMessage: record.Commit.Message, | |||
| Committer: record.Commit.Committer, | |||
| CommitMetadata: record.Commit.Metadata, | |||
| MergeSource: record.MergeSource.String(), | |||
There was a problem hiding this comment.
Is this left out from lua type on purpose? (https://github.com/treeverse/lakeFS/blob/master/pkg/actions/lua.go#L47)
There was a problem hiding this comment.
No, It is a bug - will fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new field
merge_sourceinclude source branch/tag/commit as requested.The current event include
source_refwhich resolved to the specific commit the merge operation will merge.Close #8707